[Pm-utils] [patch review request] Remove hardcoded /usr/lib/pm-utils/functions dependence

Victor Lowther victor.lowther at gmail.com
Wed Jan 30 19:54:23 PST 2008


On Jan 30, 2008 8:27 PM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2008/1/31, Michael Biebl <mbiebl at gmail.com>:
> > One way to simplify this is as follows:
> >
> > sleep_in_scripts = foo.in bar.in baz.in
> > sleep_SCRIPTS=$(sleep_in_scripts:.in=)
> > CLEANFILES=$(sleep_SCRIPTS)
> > do_subst = ...
> > %: %.in Makefile
> >         $(do_subst) $< > $@
> >
> > %: %.in is a gnu make extension though.

It turns out that there is a POSIX-ish way of doing this (I think).

> Oh, and pm/functions sources /usr/lib/pm-utils/defaults and uses fixed
> paths like /etc/pm
> in souce_configs and /usr/lib/pm-utils in find_hooks.

Patch attached.  This applies over the top of the previous patch.
It is also largeish due to the rename of functions to functions.in.
Also removed the executable bits from the .in files to emphasize their
non-executability.

> Cheers,
> Michael
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: script-portability-try-2-and-a-half.patch
Type: text/x-diff
Size: 17577 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/pm-utils/attachments/20080130/810f8901/attachment-0001.patch 


More information about the Pm-utils mailing list