[Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

[Michael Biebl]

2008/3/17, Victor Lowther <victor.lowther at gmail.com>:
> On Mon, 2008-03-17 at 01:13 +0100, Michael Biebl wrote:
>  > 2008/3/17, Victor Lowther <victor.lowther at gmail.com>:
>  > >
>  > > After a bit more review, your patch was not honoring QUIRK_NONE.  I
>  > >  readded support for it and pushed changes upstream.
>  >
>  > Good point. You should have added it after
>  > [ $ACPI_SLEEP -ne 0 ] && OPTS="$OPTS --acpi_sleep $ACPI_SLEEP"
>  > though, to make absolutely sure, that OPTS is zero.
>
>
> Not really. :)  The behaviour that 99video uses is to set the acpi_sleep
>  flag based on quirks no matter the state of QUIRK_NONE.  This patch
>  brings the uswsusp code in line with that logic.

acpi flags are quirks just like vbe post. QUIRK_NONE should skip all quirks.

>  Whether this is correct behaviour is another question, but the logic
>  99video uses has been that way for a long time and I don't want to mess
>  with it without good cause.

Not really that long.
The last officially release version (0.99.4) didn't have support for
QUIRK_NONE yet.
You added support for QUIRK_NONE on 28.02.
Your initial version skipped 99video completely.
On 01.03 (two weeks ago), you restructured 99video and since then acpi
flags were not skipped any more (the commit log doesn't tell why)

There is imho no good reason, why we should treat acpi flags special.
Imho we should fix 99video.

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?