[Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

[Victor Lowther]

On Mon, 2008-03-17 at 02:31 +0100, Michael Biebl wrote:
> 2008/3/17, Victor Lowther <victor.lowther at gmail.com>:
> > On Mon, 2008-03-17 at 01:55 +0100, Michael Biebl wrote:
> >  > 2008/3/17, Victor Lowther <victor.lowther at gmail.com>:
> >
> > > > Not really. :)  The behaviour that 99video uses is to set the acpi_sleep
> >  > >  flag based on quirks no matter the state of QUIRK_NONE.  This patch
> >  > >  brings the uswsusp code in line with that logic.
> >  >
> >  > acpi flags are quirks just like vbe post. QUIRK_NONE should skip all quirks.
> >  >
> >  > >  Whether this is correct behaviour is another question, but the logic
> >  > >  99video uses has been that way for a long time and I don't want to mess
> >  > >  with it without good cause.
> >  >
> >  > Not really that long.
> >  > The last officially release version (0.99.4) didn't have support for
> >  > QUIRK_NONE yet.
> >  > You added support for QUIRK_NONE on 28.02.
> >  > Your initial version skipped 99video completely.
> >  > On 01.03 (two weeks ago), you restructured 99video and since then acpi
> >  > flags were not skipped any more (the commit log doesn't tell why)
> >
> >
> > I stand corrected. I did not get the quirk_none logic from preexisting
> >  pm-utils code. I apoligise for the confusion.
> >
> >
> >  > There is imho no good reason, why we should treat acpi flags special.
> >  > Imho we should fix 99video.
> >
> >
> > After a bit more thinking, I remember where I got that logic -- from
> >  s2ram-x86.c in the uswsusp source code.  Specifically, this bit:
> 
> Color me stupid, but why does the s2ram code imply this logic?
> s2ram simply has no --quirk-none option.

The logic I followed was "what does the s2ram_hacks() code do even if we
called s2ram with --force and no other options?"  I then rewrote the
99video hook to match the apparent behaviour of s2ram in that case as
closely as I could determine it.

> no quirks, stupid as it sounds, means no quirks for me.

It is entirely possible I misread the s2ram code. I am willing to make
--quirk-none skip everything again, with the understanding that I will
revert it if we start getting weird 99video-related bug reports. 

> Michael
> 
-- 
Victor Lowther
Ubuntu Certified Professional