[Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

[Victor Lowther]

On Sun, 2008-10-05 at 23:05 +0200, Michael Biebl wrote:
> I promise, this will the last one for today ;-)
> 
> I'll sum up the outstanding issues:
> 
> * acpi_flags not reset

Will do.

> * /var/run/pm-utils/* not cleaned up after execution

Won't do.  It is too useful for debugging, and we clean up before every
run anyways.

> * --auto-quirks not working

/me sighs -- I need to have hardware around that actually has the
aforementioned quirks, or not try to write code and sooth an infant at
the same time.

diff --git a/pm/sleep.d/00auto-quirk b/pm/sleep.d/00auto-quirk
index 0f9bcce..839c2c0 100755
--- a/pm/sleep.d/00auto-quirk
+++ b/pm/sleep.d/00auto-quirk
@@ -6,7 +6,7 @@ do_add_quirks()
 {
        add_parameters $(lshal | \
        awk -F '[. ]' \
-               '/  power_management.quirk.[a-z_]+ = true/ \
+               '/  power_management.quirk.[0-9a-z_]+ = true/ \
                        {gsub(/_/, "-", $5); printf("--quirk-%s", $5)}')
 }
 

> * man page not up-to-date with regard to SLEEP_MODULE and auto.
> Are SUSPEND_MODULE, HIBERNATE_MODULE and SUSPEND_HYBRID_MODULE
> variables that are meant to be configurable by the user or pure
> internal implementation detail? If the former, they should be
> mentioned in the man page

They are an internal implementation detail for now.  I toyed with the
idea making them a user-configurable setting, but decided against it --
the recent Ubuntu s2ram debacle convinced me that would be a Bad Idea.
<rant>
Out of all the bugs that got filed against it, only one person appeared
to have even read the pm-utils documentation on how to write a suspend
module before submitting a patch, and his is the only halfway sane one.
</rant>

> * The new hook ordering conventions should imho be mentioned/explained
> in the man page in the FILES section.

arrgh, documentation. XML is a plot to destroy my brain, I swear.

> Cheers,
> Michael
> 
-- 
Victor Lowther
Ubuntu Certified Professional