[Pm-utils] [PATCH] fix handling of command line parameters and function calls

[Victor Lowther]

On Sat, 2009-12-05 at 23:09 -0600, Robby Workman wrote:
> On Sat, 05 Dec 2009 22:50:44 -0600
> Victor Lowther <victor.lowther at gmail.com> wrote:
> 
> > On Thu, 2009-11-19 at 20:26 +0100, Christian Krause wrote:
> > > 
> > > during some debugging I've probably found some bugs related to
> > > save/restore the pci settings. Most likely they are just typos, but
> > > it looks like that they may result wrong (or no) function calls.
> > > 
> > > Starting from hal, the correct command line parameter to for saving
> > > the pci config seems to be:
> > > "--quirk-save-pci".
> > > 
> > > Problem 1:
> > > In pm/sleep.d/98smart-kernel-video in the function
> > > "remove_all_video_quirks()" a parameter named "--quirk-pci-save" is
> > > referenced for deletion. I assume this should be "--quirk-save-pci".
> > > 
> > > Problem 2:
> > > The file pm/sleep.d/99video also assumes the wrong quirk command
> > > line parameter ("--quirk-pci-save"). Additionally in this file is
> > > also an internal inconsistency:
> > > If the pci quirk should be applied, the function "pci_save" should
> > > be called:
> > > 
> > > "quirk "${QUIRK_PCI_SAVE}" &&            pci_save"
> > > but the correct name of this function as defined in the same file is
> > > "save_pci()"
> > > 
> > > The same applies then for "restore_pci".
> > > 
> > > Please find a patch which solves all of these problems below. Please
> > > note, that these issues did not cause any trouble for me so far, but
> > > using the wrong command line parameters and function names seems to
> > > be really wrong and may lead to problems later with respect to bug
> > > fixing etc.
> > > 
> > > It would be great if anybody could look at my patch and consider
> > > applying it. ;-) Thanks!
> > > 
> > 
> > Ouch -- I must have been asleep at the wheel when adding this.  I will
> > fix it up and apply it to the current code.
> 
> 
> Any chance of a 1.2.7 release then?

Yep.

> 
> -RW