[Pm-utils] [PATCH] fix handling of command line parameters and function calls related to save/restore pci

[Christian Krause]

Hi,

during debugging I've probably found some bugs related to save/restore-pci. Most likely they are just typos, but it looks like that they may result wrong (or no) function calls.

Starting with hal, the correct command line parameter for saving the pci config seems to be:
"--quirk-save-pci".

Problem 1:
However, in pm/sleep.d/98smart-kernel-video in the function "remove_all_video_quirks()" a parameter named "--quirk-pci-save" is referenced for deletion. I assume this should be "--quirk-save-pci".

Problem 2:
The file pm/sleep.d/99video also assumes the wrong quirk command line parameter ("--quirk-pci-save"). Additionally, in this file is also an internal inconsistency:
If the pci quirk should be applied, the function "pci_save" should be called:

"quirk "${QUIRK_PCI_SAVE}" &&            pci_save"
but the correct name of this function as defined in the same file is
"save_pci()"

The same applies then for "restore_pci".

Please find attached a patch which corrects all of these problems. Please note, that these issues did not cause any real trouble for me so far, but using the wrong command line parameters and function names seems to be really wrong and may lead to problems later with respect to bug fixing etc.

It would be great if anybody could look at my patch and consider applying it. ;-) Thanks!


Best regards,
Christian






-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-handling-of-command-line-parameters-and-function.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/pm-utils/attachments/20091119/48d58a43/attachment.bin