Patch to improve error message when unable to initialize authority via D-Bus

Marat BN maratbn at gmail.com
Thu Mar 14 16:30:02 PDT 2013


Hello polkit developers,

I have a tiny patch for you, which improves the error message when
polkit is unable to initialize authority via D-Bus.

Attaching the patch file
'2013-03-14--01--patch--better-error-message-regarding-DBus.txt'.

The only addition to the message is to add a hint "via D-Bus", so that
the user realizes that the B-Bus service must be running for polkit to work.

Personally I'm on a Gentoo system on which the D-Bus service was not
enabled by default.  I was using another piece of software that depended
on polkit, and I kept getting a cryptic error message.  This hint
regarding D-Bus would have saved me some time.

Hope this patch is acceptable, and the improved error message saves more
time for more people!

Let me know if the patch is good in the format I'm sending it, or if you
need it resent in a different format.

Thanks for developing polkit!


-- Marat
-------------- next part --------------
--- src/polkit/polkitauthority.c--BACKUP--2013-03-14--01	2013-03-14 16:05:56.220100147 -0700
+++ src/polkit/polkitauthority.c	2013-03-14 16:05:59.560100428 -0700
@@ -324,7 +324,7 @@
                                                     &authority->initialization_error);
   if (authority->proxy == NULL)
     {
-      g_prefix_error (&authority->initialization_error, "Error initializing authority: ");
+      g_prefix_error (&authority->initialization_error, "Error initializing authority via D-Bus: ");
       goto out;
     }
   g_signal_connect (authority->proxy,


More information about the polkit-devel mailing list