[PATCH v3 0/4] Pull polkit forward to mozjs24

Colin Walters walters at verbum.org
Tue Nov 22 01:47:22 UTC 2016


Just a note, me applying any patches to polkit is blocked on
https://bugs.freedesktop.org/show_bug.cgi?id=97763

I took a quick look through the patches and they seemed
fine to me.  It's definitely worth making forward progress
on this, maybe one of the other people with commit
access can apply them? 

On Thu, Sep 8, 2016, at 05:04 PM, Jeremy Linton wrote:
> Ping?
> 
> Has anyone had a chance to try this, or look at the code?
> 
> Thanks,
> 
> 
> 
> On 08/26/2016 02:01 PM, Jeremy Linton wrote:
> > Polkit is out of date with respect to supported versions of mozjs. These
> > patches start moving polkit forward again. Right now they are just to
> > mozjs24 which is one of the first C++ only JSAPI versions of spidermonkey
> > and is a good starting point for evolving polkit. Moving it forward to 38 or
> > 45 involves further effort.
> >
> > v2->v3:
> >   Seems v2 got eaten by the mail system, which is just as well as there
> >     were some small formatting/etc issues with it.
> >   Fix tab->space issues in patch 3
> >   Add additional patch to replace the autocompartment declartions.
> >
> > v1->v2:
> >   Removed #ifdefs that continued to allow polkit to build with mozjs17/185
> >
> >
> > Jeremy Linton (4):
> >   change mozjs interface module to c++
> >   Cleanup configure and add support for mozjs24
> >   Fix warnings caused by building with C++
> >   Replace autocompartment
> >
> >  configure.ac                                       |  17 +-
> >  src/polkitbackend/Makefile.am                      |   7 +-
> >  ...djsauthority.c => polkitbackendjsauthority.cpp} | 203 +++++++++------------
> >  test/polkitbackend/Makefile.am                     |   3 +
> >  4 files changed, 102 insertions(+), 128 deletions(-)
> >  rename src/polkitbackend/{polkitbackendjsauthority.c => polkitbackendjsauthority.cpp} (93%)
> >
> 
> _______________________________________________
> polkit-devel mailing list
> polkit-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/polkit-devel


More information about the polkit-devel mailing list