<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="en-DE" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal"><span lang="DE" style="font-size:11.0pt;mso-fareast-language:EN-US">Hi Jan,<o:p></o:p></span></p> <p class="MsoNormal"><span lang="DE" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">that’s interesting, I can see the log messages during polkitd startup but not during runtime.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">I’ve double checked with a request which triggers polkit authorization and I can’t see the logs during runtime.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">If you prefer to have the logging bound to the ‘—no-debug’ switch, I’m fine with that.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">But I haven’t checked the code for the required changes.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Kind regards<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Michael<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div id="mail-editor-reference-message-container"> <div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">On 20.07.23, 13:09, "Jan Rybar" <jrybar@redhat.com> wrote:<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">Hello Michael,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">Thanks for the patch! I'm not sure it's really safe to write out about every loaded script though, because that will flood the journal with tens of messages on every polkit event. The parsers log every error during loading the files and I believe there are not that many .rules files to have trouble listing their directories. Right? <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">I'm sure we can think up an ideal (or at least sufficient) solution. What I'm thinking about is passing the --no-debug switch to duktapeauthority.c and listing the loaded rules only in debug mode. Would that be ok?<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">Cheers,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">Jan<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">On Thu, Jul 20, 2023 at 10:44 AM Michael Trapp <<a href="mailto:michael.trapp@sap.com">michael.trapp@sap.com</a>> wrote:<o:p></o:p></span></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt">Log each successfully loaded rule file. At the moment there is only<br> a summary message wich does not include any further information<br> about the loaded files.<br> ---<br> src/polkitbackend/polkitbackendjsauthority.cpp | 3 +++<br> 1 file changed, 3 insertions(+)<br> <br> diff --git a/src/polkitbackend/polkitbackendjsauthority.cpp b/src/polkitbackend/polkitbackendjsauthority.cpp<br> index 004748a..9373bf5 100644<br> --- a/src/polkitbackend/polkitbackendjsauthority.cpp<br> +++ b/src/polkitbackend/polkitbackendjsauthority.cpp<br> @@ -240,6 +240,9 @@ load_scripts (PolkitBackendJsAuthority *authority)<br> }<br> <br> //g_print ("Successfully loaded and evaluated script `%s'\n", filename);<br> + polkit_backend_authority_log (POLKIT_BACKEND_AUTHORITY (authority),<br> + "Successfully loaded and evaluated script %s",<br> + filename);<br> <br> num_scripts++;<br> }<br> -- <br> 2.39.2 (Apple Git-143)<o:p></o:p></span></p> </blockquote> </div> </div> </div> </div> </body> </html>