[Poppler-bugs] [Bug 8111] New: ~2% speedup by avoiding char -> UGooString conversions on Dict::find

bugzilla-daemon at annarchy.freedesktop.org bugzilla-daemon at annarchy.freedesktop.org
Sat Sep 2 17:04:54 PDT 2006


Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=8111          
     
           Summary: ~2% speedup by avoiding char -> UGooString conversions
                    on Dict::find
           Product: poppler
           Version: unspecified
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: kkowalczyk at gmail.com


Currently every Dict::find(char *) (which are a majority) needs to convert char
* to UGooString, which involves memory allocations.

This patch implements ability to directly find(char *) by adding
UGooString::cmp(char *) that has the same semantics as
UGooString::cmp(UGooString(char*)).

Also converting tabs to spaces so that it always has correct indentation
(regardless of your current tab settings) and small refactoring to use
dictLookupBool() and dictLookupInt() for simpler code.          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


More information about the Poppler-bugs mailing list