[Poppler-bugs] [Bug 8315] New: Use buffered i/o in ImageStream::getLine() for 10-25% rendering speed improvement

[bugzilla-daemon at annarchy.freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=8315          
     
           Summary: Use buffered i/o in ImageStream::getLine() for 10-25%
                    rendering speed improvement
           Product: poppler
           Version: unspecified
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: kkowalczyk at gmail.com


The attached patch makes ImageStream::getLine() use buffered i/o.

For certain kind of images it gives 10-25% speed improvement in rendering page.

It also shows that virtual getChar() is very expensive. Before the change,
FlateStream::getChar() and ImageStream::getLine() were 2 most expensive
functions. After the change, ImageStream::getLine() dropped to position 17 and
FlateStream::readSome() (which replaced FlateStream::getChar()) to position 16.

And if someone is interested in improving the speed of this scenario even
futher, now the most expensive function is Splash::fillImageMask() and 3rd most
expensive is _ftol2_pentium4 (called from Splash::fillImageMask()) so improving
fillImageMask() would give the biggest boost.          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.