[Poppler-bugs] [Bug 13338] Making pdftops preserve PDF page labels

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 29 01:02:09 PST 2007


http://bugs.freedesktop.org/show_bug.cgi?id=13338


bradh at frogmouth.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bradh at frogmouth.net




------- Comment #3 from bradh at frogmouth.net  2007-11-29 01:02 PST -------
As I understand it, the change we are looking for (in pseudocode form) is:
if we have a page label:
        write "%%Page pageLabel {1:[seqPage]}" to the file
else:
        write "%%Page {0:pageNum} {1:[seqPage]}" to the file


There has to be a cleaner patch than this. In any case, this part of the patch
is wrong:
   if (mode == psModePS) {
-    writePSFmt("%%Page: {0:d} {1:d}\n", pageNum, seqPage);
+    writePS("%%Page: ");
+    if (pageLabel) {
+      writePSText(pageLabel);
+    } else {
+      writePSFmt("{0:d}", pageNum);
+    }
+    writePSFmt(" {0:d}\n", seqPage);
     writePS("%%BeginPageSetup\n");
   }

Since the writePSFmt(" {0:d}\n", seqPage); should be writePSFmt(" {1:d}\n",
seqPage);


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


More information about the Poppler-bugs mailing list