[Poppler-bugs] [Bug 14126] pdftotext not checking success of fseek(), so gives misleading errors if input not seekable

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=14126





--- Comment #2 from Albert Astals Cid <tsdgeos at terra.es>  2008-03-20 14:22:22 PST ---
Do you read minds or something?

Just yesterday i was having a look at this bug report and really i don't know
what to do.

Using exceptions is a no go, as the whole project does not uses exceptions. So
one has to resort to other solutions.

For FoFiBase::readFile and GfxFont::readExtFontFile it is easy because they
return a * that can be NULL in case of error, but all the Stream functions
return void, changing them to bool is not acceptable since that would mean
checking for errors in hundreds of places where that's not checked currently.

So the solution i liked most was something like return NULL in
FoFiBase::readFile and GfxFont::readExtFontFile along with an error() call when
we can not seek, and for all the others i think one should try to do a
setPos(1), getPos in PDFDoc::setup and if getPos returns != 1 we just assume
the stream is not seekable and return a false in GBool.

Could you try coding such a patch?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.