[Poppler-bugs] [Bug 23078] integer overflow in PDF parsing

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23078


Jakub Wilk <ubanus at users.sf.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubanus at users.sf.net




--- Comment #3 from Jakub Wilk <ubanus at users.sf.net>  2009-08-10 01:15:33 PST ---
Note that, strictly speaking, your fix is invalid. Signed integer overflow is
undefined behaviour in C++, which means that the compiler may assume that it
will not happen. That is, the compiler is free to optimize out the branch where
you set overflownInteger = gTrue.
Either you should refrain from triggering the overflow (by testing for
something like xi<INT_MAX/10-1 *before* multiplication) or use -fwrapv gcc
option.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.