[Poppler-bugs] [Bug 25755] Sample PDF works in pre-0.11.2 poppler, breaks in post-0.11.1

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25755





--- Comment #5 from Dennis Sheil <dsheil at vartmp.com>  2009-12-22 07:38:00 PST ---
Created an attachment (id=32245)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32245)
A reversion of the bad commit for the current code

As I said, 512b2c654fd80c83b82e7adc828a478a18de17ab is the bad commit which
removes the functionality.  That commit was made on July 26, 2009.

I just grabbed poppler from git with the last commit being
df0ccddb7f784b4a8564beda51b3047cb9e3611a (December 18, 2009).  The patch I put
here rolls back the bad 512b...ab commit against this latest code
(df0c...611a).  After installing this patch on df0c...611a, I can now see the
deleted text.

I am not completely familiar with cairo and poppler and do not know all the
reasons for the 512b...17ab commit.  What it appears like to me is poppler had
some old hacky stuff in it as a workaround prior to Cairo coming out with the
ability to do "cairo_pattern_set_extend (pattern, CAIRO_EXTEND_PAD);".  The old
hacks were taken out, the new Cairo calls were put in.  And they were hacks on
the poppler end - there's mallocing, lack of good error handling etc.  But the
old code still works, and the 512b...17ab code ultimately does not.

My patch puts the old mallocing, bad error handling but working code back in as
a child of the last commit (df0c...611a).  The goal I suppose would be to fix
it so it is working, and then work to get the 512b...17ab code that implements
cairo_pattern_set_extend() with CAIRO_EXTEND_PAD properly.

As I said, I don't fully understand poppler, cairo, gradient patterns etc.  If
I have time I will look at this some more.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.