[Poppler-bugs] [Bug 19670] Colorizing text in pattern colorspace solved

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Feb 1 13:13:06 PST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=19670





--- Comment #14 from Albert Astals Cid <tsdgeos at terra.es>  2009-02-01 13:13:06 PST ---
Some more comments: 
 state->setRender(7); <-- sucks a bit
 state->setRender(7 /* Set foo bar */); <-- would be much more nice :-)

I see that in 
 Gfx::opEndText
you do 
 out->restoreState(state);
but you are also doing it in SplashOutputDev::endTextObject that also gets
called by Gfx::opEndText so i'm not sure if that's really needed, also might be
that i'm not totally understanding what the code does :D

Waiting for some feedback on your side before proceeding.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list