[Poppler-bugs] [Bug 19670] Colorizing text in pattern colorspace solved

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19670





--- Comment #15 from thomasf <Thomas.Freitag at alfa.de>  2009-02-02 02:31:31 PST ---
>  * In patch from comment #8 I'd say that in Gfx::opEndText you are missing a 
>        delete colorSpaceText;
>    before
>        colorSpaceText = NULL;
I don't think so: 
                  state->setFillColorSpace(colorSpaceText);
will leave it up to GfxState.cc to delete colorSpaceText next time the fill
colorspace will be changed...

>  * In patch from comment #8: we don't use exceptions in poppler so that code
> has to be removed/reworked

Okay, I need that to find the three bugs in case of SPLASH_CMYK (wrong
blending, wrong offset in setSoftMask, missing enum in splashColorModeNComps),
to look at the bitmaps and therefore it is only inside a compiler switch,
should not be part of released code.

>  * In patch from comment #9 I guess there's a 
>        void PSOutputDev::beginTextObject(GfxState *state);
>    missing in PSOutputDev.h

Yes, You're true. I merged the code from my changes in xpdf and just looked, if
I'm able to compile it...

>  * What is CIOutputDev for?
> 

I need to get some information about the pdf, at least what colorspaces the pdf
is using, to decide, wether to create a monochrome, grayscale, rgb or cmyk
bitmap. It is not sufficient to walk over the objects and look which Devices
they are using, because it is allowed to use CS inside every PDF object. So its
a helper device for ColorInfo.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.