[Poppler-bugs] [Bug 19670] Colorizing text in pattern colorspace solved

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19670





--- Comment #10 from thomasf <Thomas.Freitag at alfa.de>  2009-01-27 05:55:49 PST ---
(In reply to comment #3)
> Thanks for the code!
> 
> But sending a zip file with all the changes files inside is quite difficult for
> us to work.
> 
> Can you please attach a proper diff against the git master development tree or
> at least against poppler 0.10.3 instead of the full files?
> 
> That will make easier for us to see the differences.
> 
> If possible also provide separate patches for each change, i mean probably 
> 
> Lexer.cc: Helper for printing PDF commands. Useful to examine PDFs with
> deflated commands.
> 
> Can go in a patch totally separated from the rest of the code.
> 
> Keep in mind that reviewing changes is not easy and the smaller the patches the
> easier is letting them go inside the development tree.
> 

I attached now git diffs in 5 smaller pieces and add the changes for colorizing
text in PSOutputDev, too. I removed the changes for color delta, because they
are mainly part of a patch to pdftops, I will make a new bug report with a
patch for color delta after these changes are committed. I didn't made a patch
for the new files CIOutputDev.cc and CIOutputDev.h, but You're free to add them
to the development tree. If You decide to do so, I will support them in futur,
too.
In the zip file there was on file missing, SplashTypes.h, needed for compiling,
but it is part of the patches now.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.