[Poppler-bugs] [Bug 5589] image scaling with cairo is poor quality

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=5589





--- Comment #36 from Chris Wilson <chris at chris-wilson.co.uk>  2009-11-17 02:26:46 PST ---
(In reply to comment #34)
> Created an attachment (id=31245)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=31245) [details]

Some comments first on the presentation of the patch:

 * just send the patch by itself, there's no need to include the modified file
as well - the patch is much easier to read.

 * generate the patch using "diff -urNp old new" when doing so manually.
However, git will generate easy-to-read patches with either "git diff", or
preferably "git format-patch -1". Note the latter will require you to commit
your changes and so also will include a changelog entry and a record of
authorship. (And means we can very simply apply the patch to our git trees.)

 * Please try to conform to the coding style of the file you are modifying.

My opinion is that this is vital to get this into pixman as soon as possible -
however, the core poppler developers want to get a workaround into poppler now.
In terms of implementation, I see nothing fundamentally wrong with the patch
(it implements a basic 2D box filter, that would be worth a comment or a better
function name!) - though the patches proposed for pixman should achieve better
performance.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.