[Poppler-bugs] [Bug 24525] New: poppler: missing readEmbFontFile return value checks

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24525

           Summary: poppler: missing readEmbFontFile return value checks
           Product: poppler
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: thoger at redhat.com


Created an attachment (id=30400)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=30400)
Missing readEmbFontFile return value checks

GfxFont::readEmbFontFile can return NULL if object expected to contain font
stream is not stream.  There are couple of calls where the return value is not
checked - in PSOutputDev and GfxFont.  There are checks for NULL return value
in SplashOutputDev and ArthurOutputDev.

Value returned is later passed to FoFi*::make, which leads to FoFi*::parse that
assumes that file is not NULL.  NULL file can hence cause crash.

Attached is possible patch that adds checks where they are missing.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.