[Poppler-bugs] [Bug 22305] Allow building win32 relocatable dll with win32 native font backend

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22305





--- Comment #6 from Albert Astals Cid <tsdgeos at terra.es>  2010-01-01 16:51:07 PST ---
Wondering if in first patch 
-#ifdef _MSC_VER
+#if defined(_MSC_VER) || WITH_FONTCONFIGURATION_WIN32
should just be
-#ifdef _MSC_VER
+#if WITH_FONTCONFIGURATION_WIN32
because you did 
-#ifndef _MSC_VER
+#if WITH_FONTCONFIGURATION_FONTCONFIG
and i'd prefer it to be kind of symmetric.

And
AM_CPPFLAGS = -D_WIN32_IE=0x0501
needs a comment for us non windows people to understand what it is

In the second i guess
#if ENABLE_RELOCATABLE && defined(_WIN32)
could just be
#if ENABLE_RELOCATABLE
?
Maybe even calling it ENABLE_WIN32_RELOCATABLE ?

Also i guess asking you to write the cmake counterparts is too much, right?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.