[Poppler-bugs] [Bug 22305] Allow building win32 relocatable dll with win32 native font backend

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22305


Hib Eris <hib at hiberis.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hib at hiberis.nl




--- Comment #7 from Hib Eris <hib at hiberis.nl>  2010-01-10 10:47:56 PST ---
(In reply to comment #6)

Hi,

First, sorry for my late reply, I forget to subscribe to this bug when
submitting the patches.

> Wondering if in first patch 
> -#ifdef _MSC_VER
> +#if defined(_MSC_VER) || WITH_FONTCONFIGURATION_WIN32
> should just be
> -#ifdef _MSC_VER
> +#if WITH_FONTCONFIGURATION_WIN32

That would certainly be the better thing to do, as that would specify the build
based on the configuration parameter WITH_FONTCONFIGURATION_WIN32 only, not on
the compiler used in the build. The reason I did not do that is that it would
also require changes in the configuration settings for the Microsoft Visual C
compiler (in makefile.vc), and in the CMake file. I have created a new patch,
but I cannot test it on Windows myself. So I hope there is someone else who can
test this patch on Windows with cmake and/or msvc.

> And
> AM_CPPFLAGS = -D_WIN32_IE=0x0501
> needs a comment for us non windows people to understand what it is

Hmm, indeed, that is not very clear. Thinking about it a bit more, it also
should be in configure.ac because all parts of poppler should be compiled with
this setting. I changed this in my new patch.

> In the second i guess
> #if ENABLE_RELOCATABLE && defined(_WIN32)
> could just be
> #if ENABLE_RELOCATABLE
> ?
> Maybe even calling it ENABLE_WIN32_RELOCATABLE ?

Okay, I renamed it to ENABLE_WIN32_RELOCATABLE.

> Also i guess asking you to write the cmake counterparts is too much, right?

Maybe, maybe not: In the new patches, I did my best to make it work with cmake,
but I have only tested those on Linux. I cannot say if they work on Windows as
well, but I think they do.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.