[Poppler-bugs] [Bug 28780] Add getLabel method to FormWidget

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28780

--- Comment #4 from Albert Astals Cid <tsdgeos at terra.es> 2010-07-23 14:25:56 PDT ---
I am assuming you have actually tested getFullyQualifiedName, right?

I have three small gotchas, first, thought it is everywhere in poppler, you
don't need to do 

+  if (partialName)
+    delete partialName;

just do

+  delete partialName;

Second is that the indentation in getFullyQualifiedName seems a bit fishy, some
lines use 1 space only

I'm actually a bit more concerned about the third, you concatenate strings in
getFullyQualifiedName but noone guarantees they all will be either unicode
encoded or not, so we could end up concatenating some utf 8 encoded and some
non utf8 encoded ones, right? Though i don't really see how we can fix this,
maybe we can just hope the document encodes all T fields the same way?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.