[Poppler-bugs] [Bug 28442] New: Poppler-0.12.4 fails to compile due to _XOPEN_SOURCE on some OSX and Solaris

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28442

           Summary: Poppler-0.12.4 fails to compile due to _XOPEN_SOURCE
                    on some OSX and Solaris
           Product: poppler
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: grobian at gentoo.org


After the fix from bug #27610, poppler no longer compiles on OSX 10.4 and
Solaris 10.

The Cmakefiles unconditionally inject _XOPEN_SOURCE now causing all kinds of
problems.  Simply sedding this out by e.g.
  sed -i -e '/add_definitions/d' cmake/modules/PopplerMacros.cmake
makes poppler compile on before mentioned platforms.

There is a difference between cmake and configure here, as configure seems to
at least only add when some configure flag is given, and cmake just
unconditionally adds it (together with some warning flags that make every file
emit at least 3 warnings for no good reason to me).

I suggest to see if setting _XOPEN_SOURCE is necessary at all for the general
case, and if it is, to build a check that figures out if it is necessary, in
what form, and/or doesn't break the build.

I can provide information and/or try fixes if necessary.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.