[Poppler-bugs] [Bug 28442] Poppler-0.12.4 fails to compile due to _XOPEN_SOURCE on some OSX and Solaris

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28442

--- Comment #2 from Fabian Groffen <grobian at gentoo.org> 2010-06-08 11:54:29 PDT ---
ok, we've got this patch applied:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-text/poppler/files/poppler-0.12.4-xopen_source.patch?revision=1.1&view=markup

Technically, that means indeed we are not on version 0.12.4 exact.  However the
patch is already committed, so next release will suffer from this.

If DEFAULT_COMPILE_WARNINGS_KDE must be set, then the original bug (failure to
compile on FreeBSD) would not be solved.  I don't understand enough from cmake
to judge if _XOPEN_SOURCE is injected based on DEFAULT_COMPILE_WARNINGS_KDE, or
not, but since we don't seem to set it, which then means it's enabled by
default.

My observations in short:
- FreeBSD needs _XOPEN_SOURCE=600
- OSX 10.4 and Solaris break on setting _XOPEN_SOURCE to any value
- _XOPEN_SOURCE is only added when DEFAULT_COMPILE_WARNINGS_KDE, hence fix or
breakage is conditional

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.