[Poppler-bugs] [Bug 7107] Windows portability fixes

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=7107





--- Comment #10 from Pino Toscano <pino at kde.org>  2010-03-22 03:43:23 PST ---
(In reply to comment #8)
> 1) in goo/gfile.cc _MAX_PATH probably can be defined to MAX_PATH (which is
> defined on mingw)

In goo/gfile.cc I see a limits.h included only on !_WIN32; do both MSVC and
mingw provide it? Also, does it provide such _MAX_PATH, or should it be changed
to the "classic" PATH_MAX?

> 2) in poppler/Annot.cc strdup is used which seems to be a non-ansi extension
> according to mingw. This means that the -ansi keyword would need to be removed
> or a replacement be found (also _strdup is not defined).

Hm ok, I'll move it to a Linux-only section.

> 3) in poppler/GlobalParamsWin.cc was an error about settings _WIN32_IE to at
> least 0x0500, so I did that. This fix is the only one that could be committed
> directly.

Fixed locally.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.