[Poppler-bugs] [Bug 2807] doesn't handle text rendering modes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=2807

--- Comment #31 from thomasf <Thomas.Freitag at alfa.de> 2010-09-18 00:47:45 PDT ---
(In reply to comment #30)
> Still causes some regressions, for example the "Segurança no internet" text in
> https://bugzilla.gnome.org/attachment.cgi?id=148574
> 
> We are stuck between a rock and a hard place :-/
> 
> I think we could go with "Accept the patch without the antialias fix" and leave
> for the future fixing antialias shadings in the splash backend.
> 
> What you guys think?

"Segurança no internet" uses shading from left to right, the bug fix I
implemented considers always shading from top to bottom, therefore it doesn't
work for this PDF. The patch without the antialias fix works for PSOutputDev
and CairoOutputDev because these devs implement the shading routines
themselves. Therefore I think that You should accept the patch without the
antialias fix first.
As I figured out, SplashOutputDev is the only device which doesn't implement
the shading routines and use the Gfx algorithm with switching antialias off. In
filling the area in small pieces, it is hard to decide wether a clipping line
is a "inside" line without antialias or if it is an outer line where antialias
should be done. Therefore I think the clearest and understandable way is to
implement the shading routines in SplashOutputDev too.
This could be done in three steps:
1. Implement the shading algorithms in SplashOutputDev, too, by copying the
algorithms from Gfx without antialising.
2. Implement the shading routine used by the PDFs of this bug with antialias in
SplashOutputDev. It is easier to decide if it is outer or inner line in
SplashOutputDev when we look at the complete clipping path.
3. Implement the other two shading routines with antialias in SplashOutputDev,
too.
Without starting the work I can't estimate if implementing this steps will take
only a few hours or some days, but I would think that doing step 1 should be
quite easy.
So if You agree, accept the patch without the antialias fix and open an new bug
and assign it to me. Then I'll start to implement it in my free time!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.