[Poppler-bugs] [Bug 32890] setjmp is missing in DCTStream::init()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32890

--- Comment #3 from Albert Astals Cid <tsdgeos at terra.es> 2011-01-09 04:58:55 PST ---
There's still something that needs improvement, i did

diff --git a/poppler/DCTStream.cc b/poppler/DCTStream.cc
index 212a8bd..34db5bf 100644
--- a/poppler/DCTStream.cc
+++ b/poppler/DCTStream.cc
@@ -91,8 +91,10 @@ void DCTStream::init()
   limit = NULL;

   cinfo.err = &jerr;
-  jpeg_create_decompress(&cinfo);
-  cinfo.src = (jpeg_source_mgr *)&src;
+  if (false && !setjmp(src.setjmp_buffer)) {
+    jpeg_create_decompress(&cinfo);
+    cinfo.src = (jpeg_source_mgr *)&src;
+  }
   row_buffer = NULL;
 }


To simulate a "failure" of jpeg_create_decompress and then ran pdftoppm over a
file that uses that code and still crashes. Could you try to find what is the
problem?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.