[Poppler-bugs] [Bug 31926] pdftops-0.15.2 -level1sep inverts the image mask polarity

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 24 12:42:30 PST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=31926

--- Comment #29 from William Bader <williambader at hotmail.com> 2011-01-24 12:42:30 PST ---
I saved globalParams->getPSLevel() in a variable because I had originally
thought that I would need to test it in more places.  Also,
GlobalParams::getPSLevel() might need to lock the mutex that protects the
global parameters before reading the value of psLevel.  I thought that it was
better to call globalParams->getPSLevel() just once than to do it one or twice
for every image. I think that is why PSOutputDev has its own local copy of
level.
If you want, I can redo the patch without the local copy of level in
PreScanOutputDev or I can change the PreScanOutputDev constructor to take the
level as an argument so it never has to call globalParams->getPSLevel().
William

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list