[Poppler-bugs] [Bug 38586] support text rotation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38586

--- Comment #8 from Albert Astals Cid <tsdgeos at terra.es> 2011-06-23 00:56:46 PDT ---
@@ -297,25 +298,17 @@ int HtmlFontAccu::AddFont(const HtmlFont& font){
 }

 // get CSS font name for font #i 
-GooString* HtmlFontAccu::getCSStyle(int i, GooString* content, int j){
+GooString* HtmlFontAccu::getCSStyle(GooString* content){
   GooString *tmp;
-  GooString *iStr=GooString::fromInt(i);
-  GooString *jStr=GooString::fromInt(j);

   if (!xml) {
-    tmp = new GooString("<span class=\"ft");
-    tmp->append(jStr);
-    tmp->append(iStr);
-    tmp->append("\">");
+    tmp = new GooString("<span>");
     tmp->append(content);
     tmp->append("</span>");
   } else {
     tmp = new GooString("");
     tmp->append(content);
   }
-
-  delete jStr;
-  delete iStr;
   return tmp;
 }

Any reason why you are deleting this perfectly valid feature?


-  if( !noframes )
-  {
-      GooString* pgNum=GooString::fromInt(page);
-      tmp = new GooString(DocName);
-      if (!singleHtml){
-            tmp->append('-')->append(pgNum)->append(".html");
-            pageFile = fopen(tmp->getCString(), "w");
-      } else {
-            tmp->append("-html")->append(".html");
-            pageFile = fopen(tmp->getCString(), "a");
-      }
-      delete pgNum;
-      if (!pageFile) {
-      error(-1, "Couldn't open html file '%s'", tmp->getCString());
-      delete tmp;
-      return;
-      } 
+  if( !noframes ) {
+    GooString* pgNum=GooString::fromInt(page);
+    tmp = new GooString(DocName);
+    if (!singleHtml){
+      tmp->append('-')->append(pgNum)->append(".html");
+      pageFile = fopen(tmp->getCString(), "w");
+    } else {
+      tmp->append("-html")->append(".html");
+      pageFile = fopen(tmp->getCString(), "a");
+    }
+    delete pgNum;
+    if (!pageFile) {
+      error(-1, "Couldn't open html file '%s'", tmp->getCString());
+      delete tmp;
+      return 1;
+    }

Please do not reformat code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.