[Poppler-bugs] [Bug 42036] New: glib-demo uses deprecated GLib threading API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42036

             Bug #: 42036
           Summary: glib-demo uses deprecated GLib threading API
    Classification: Unclassified
           Product: poppler
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: glib frontend
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: amigadave at amigadave.com


Threading in GLib was changed significantly in version 2.31.0:

http://mail.gnome.org/archives/gtk-devel-list/2011-October/msg00056.html

The thread initialisation functions were deprecated, as threads are now
unconditionally enabled. This causes poppler to not build inside jhbuild, using
the latest GLib, due to g_thread_init() being called inside glib-demo:

make[4]: Entering directory
`/home/david/checkout/gnome/poppler-0.18.0/glib/demo'
  CC     main.o
main.c: In function ‘pgd_demo_get_auth_dialog’:
main.c:183:2: warning: implicit declaration of function
‘gtk_dialog_set_has_separator’
main.c: In function ‘main’:
main.c:303:2: warning: implicit declaration of function ‘g_thread_supported’
main.c:304:3: warning: implicit declaration of function ‘g_thread_init’
  CXXLD  poppler-glib-demo
main.o: In function `main':
/home/david/checkout/gnome/poppler-0.18.0/glib/demo/main.c:303: undefined
reference to `g_thread_supported'
collect2: ld returned 1 exit status
make[4]: *** [poppler-glib-demo] Error 1

Attaching a patch to fix this with a preprocessor check.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.