[Poppler-bugs] [Bug 41374] [patch] pdftops 0.18.0 makes some files twice as large

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41374

William Bader <williambader at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51823|0                           |1
        is obsolete|                            |

--- Comment #3 from William Bader <williambader at hotmail.com> 2011-09-30 18:38:47 PDT ---
Created an attachment (id=51825)
 View: https://bugs.freedesktop.org/attachment.cgi?id=51825
 Review: https://bugs.freedesktop.org/review?bug=41374&attachment=51825

revised patch

After the patch, pdftops -level2 and -level2sep output were wrong.
In my testimagemask.pdf file, some of the faces were missing.
Reverting to the older code in previous versions of poppler fixed the problem.
I made the new test to call tilingPatternFillL1() if
(level == psLevel1 || level == psLevel1Sep || (x1-x0 == 1 && y1-y0 == 1))
After this change, all of my test files produce output identical to the
previous version of pdftops (except for the "Produced by poppler" comment).
I suspect that the problem is that the code in
PSOutputDev::tilingPatternFillL2() does not handle every case that
tilingPatternFillL1() supports, and that my testimagemask.pdf file is an
example of one of those cases.
All of my test files happen to have x1-x0 == 1 && y1-y0 == 1, so I don't have
an easy way to do more testing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.