[Poppler-bugs] [Bug 52488] Segfault in splash/Splash.cc:4501

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 2 00:37:00 PDT 2012


https://bugs.freedesktop.org/show_bug.cgi?id=52488

--- Comment #11 from Thomas Freitag <Thomas.Freitag at alfa.de> 2012-08-02 07:37:00 UTC ---
(In reply to comment #9)
> Octopoid's changes make sense anyway, scaledImage can return null, so we have
> to protect against them.
> 
> Octoploid, before i can commit your patch i need your name so i can give you
> proper copyright attribution.

Yes, like always You're true. And I tested a change in tilingPattern last
weekend, but I wasn't complete satisfied with my changes, so probabbly it will
take a while.
But it would be helpful if Markus can change his patch a little bit: 

      if (scaledImg == NULL) {
        return splashErrBadArg;
      }
in case that scaleImg is null. This would be more compatible to
Splash::arbitraryTransformImage, where You, Albert, already made this change.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list