[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #22 from Albert Astals Cid <tsdgeos at terra.es> 2012-08-05 13:40:32 UTC ---
Some random quick comments from looking at the code:
 * Seems "most" of the "let make it thread safe" is adding the 
      xref = (fCopy) ? doc->getXRef()->copy() : doc->getXRef();
    stuff, have you measured how slow is copying the xref? Because if it's not
"expensive" we may just do it all the time

 * To make the "thread-safety" better we should remove PDFDoc::getXRef() and
force everyone to use Gfx:::getXRef() or ask for an XRef an input, right?

 * Should we remove the xref member in Page and use gfx->getXRef() everywhere?

 * The mutex locking seems to be very "rendering" oriented, e.g. if you are
locking  XRef::copy, why not lock XRef::add or XRef::setModifiedObject ?

 * Why do you need UniqueFileStream ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.