[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #29 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-08-06 09:48:38 UTC ---
(In reply to comment #23)
> (In reply to comment #22)
> > Some random quick comments from looking at the code:
> >  * Seems "most" of the "let make it thread safe" is adding the 
> >       xref = (fCopy) ? doc->getXRef()->copy() : doc->getXRef();
> >     stuff, have you measured how slow is copying the xref? Because if it's not
> > "expensive" we may just do it all the time
> 
> I made just one test: I rendered "cud10nebsiaol.pdf" (from bug 52488) with and
> without the patch, it took 1 second more with the patch (without threads,
> nearly half the timee with threads). But that could propably be a measuring
> error.

Yeah, I was wondering exactly the same when I looked at the code. Copying xref
doesn't look too expensive, I guess it depends on how many times the xref is
copied. Maybe we could use a global setting (or per page/document, I don't
know) for that instead of passing just another parameter to
displaySliceMethods?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.