[Poppler-bugs] [Bug 50992] library should be thread-safe

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 23 01:24:27 PDT 2012


https://bugs.freedesktop.org/show_bug.cgi?id=50992

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65478|0                           |1
        is obsolete|                            |

--- Comment #37 from Thomas Freitag <Thomas.Freitag at alfa.de> 2012-08-23 08:24:27 UTC ---
Created attachment 66013
  --> https://bugs.freedesktop.org/attachment.cgi?id=66013
revised patch

I upload here a revised patch because of several reasons:
1. The final changes of the last patch I tested just under Windows, and I once
again forgot that it is not a problem to recursive lock the same mutex with the
same thread under Windows where it runs into a dead lock under Unix.
2. I missed some crashes of the former patch because I just search for failed
tests but not for crashes. I encountered that the crashes were forced by the
shared resource dict which still uses the xref of the shared document. This is
repaired now, too.
3. I took a deeper look now into failed tests on damaged PDF documents and
encountered that I missed to copy some private members of the XRef class.

This patch runs now completely over my PDF suite on Windows and Unix (with my
test case) and has no more crashes and only a very few failed tests (13 of
1133). Two or three of these failed tests have changes because a different
external font was taken (because external fonts are now cashed on page base and
no more document base, and fetching external fonts with fontconfig is not
completely exact) and the other tests are so corrupted PDF that even the page
components cannot be fetched for all pages.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list