[Poppler-bugs] [Bug 44790] Various minor introspection improvements

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44790

--- Comment #1 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-01-15 02:48:40 PST ---
Comment on attachment 55588
  --> https://bugs.freedesktop.org/attachment.cgi?id=55588
glib: various minor introspection improvements

Review of attachment 55588:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=44790&attachment=55588)
-----------------------------------------------------------------

Thanks for the patch! just a few comments

::: glib/poppler-attachment.h
@@ +39,2 @@
>   * @count: number of bytes in @buf.
> + * @data: (closure closure): user data passed to poppler_attachment_save_to_callback()

This should be (closure), (closure closure) is the callback.

@@ +41,1 @@
>   * @error: GError to set on error, or NULL

We should probably annotate this as (out), no?

::: glib/poppler-document.cc
@@ +2497,4 @@
>   * Returns the #PopplerFormField for the given @id. It must be freed with
>   * g_object_unref()
>   *
> + * Return value: (transfer full): a new #PopplerFormField or NULL if

Use %NULL, please.

::: glib/poppler-media.h
@@ +38,2 @@
>   * @count: number of bytes in @buf.
> + * @data: (closure closure): user data passed to poppler_media_save_to_callback()

Same here, this should be (closure).

@@ +40,1 @@
>   * @error: GError to set on error, or NULL

And here we could annotate this as (out)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.