[Poppler-bugs] [Bug 45384] Various minor introspection improvements

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45384

--- Comment #3 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-01-30 06:07:55 PST ---
Comment on attachment 56312
  --> https://bugs.freedesktop.org/attachment.cgi?id=56312
glib: introspection fixes issues, don't expose PopplerAttachmentClass

Review of attachment 56312:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45384&attachment=56312)
-----------------------------------------------------------------

Thanks for the patch.

::: glib/poppler-action.h
@@ +261,5 @@
>  };
>  
> +/**
> + * PopplerActionOCGState:
> + * @type: action type

We know the action type, so add it in parentheses:

@type: action type (%POPPLER_ACTION_OCG_STATE)

@@ +263,5 @@
> +/**
> + * PopplerActionOCGState:
> + * @type: action type
> + * @title: action title
> + * @state_list: (element-type PopplerActionLayer): list of #PopplerActionLayer<-- -->s

We should explain briefly what this action is for.

@@ +264,5 @@
> + * PopplerActionOCGState:
> + * @type: action type
> + * @title: action title
> + * @state_list: (element-type PopplerActionLayer): list of #PopplerActionLayer<-- -->s
> + */

All other action types are also undocumented, I guess it's a good time to
document all of them :-P

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.