[Poppler-bugs] [Bug 52426] New: [Patch] Compilation breaks because of missing headers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52426

             Bug #: 52426
           Summary: [Patch] Compilation breaks because of missing headers
    Classification: Unclassified
           Product: poppler
           Version: unspecified
          Platform: All
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: tk at CeBiTec.Uni-Bielefeld.DE


Created attachment 64583
  --> https://bugs.freedesktop.org/attachment.cgi?id=64583
add missing includes

Compiling poppler-0.20.2 on Solaris 10 with Oracle's Solaris Studio Compiler
12.3 breaks with the following errors:

Making all in goo
make[2]: Entering directory `/vol/obj/X11/poppler/poppler-0.20.2.patched/goo'
[...]
  CXX    gstrtod.lo
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 53: Error:
The function "localeconv" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 54: Error:
The type "lconv" is incomplete.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 55: Error:
The function "strlen" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 96: Error:
The function "malloc" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 99: Error:
The function "memcpy" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 101: Error:
The function "memcpy" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 103: Error:
The function "memcpy" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 108: Error:
The function "strtod" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 118: Error:
The function "free" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 122: Error:
The function "malloc" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 123: Error:
The function "memcpy" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 127: Error:
The function "strtod" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 134: Error:
The function "free" must have a prototype.
"/vol/src/X11/poppler/poppler-0.20.2.patched/goo/gstrtod.cc", line 137: Error:
The function "strtod" must have a prototype.
14 Error(s) detected.
make[2]: *** [gstrtod.lo] Error 1
make[2]: Leaving directory `/vol/obj/X11/poppler/poppler-0.20.2.patched/goo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/vol/obj/X11/poppler/poppler-0.20.2.patched'
make: *** [all] Error 2

The attached patch fixes this issue by adding the required include statements
to goo/gstrtod.cc -- unconditionally at the moment but I can produce a variant
wrapped in an appropriate autoconf test that checks for the existence of the
headers, if necessary.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.