[Poppler-bugs] [Bug 46948] Glib patches

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46948

--- Comment #4 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-03-05 11:10:27 PST ---
Comment on attachment 57996
  --> https://bugs.freedesktop.org/attachment.cgi?id=57996
show encoding in demo

Review of attachment 57996:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=46948&attachment=57996)
-----------------------------------------------------------------

Looks good too, thanks!

::: glib/demo/fonts.c
@@ +165,5 @@
>  				name = "No name";
>  
> +			encoding = poppler_fonts_iter_get_encoding (fonts_iter);
> +			if (!encoding)
> +				encoding = "No encoding";

Maybe this could be just None, since this will look like:

Encoding: No encoding

maybe it's a bit redundant.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.