[Poppler-bugs] [Bug 46948] Glib patches

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46948

--- Comment #6 from Carlos Garcia Campos <carlosgc at gnome.org> 2012-03-05 11:16:16 PST ---
Comment on attachment 57997
  --> https://bugs.freedesktop.org/attachment.cgi?id=57997
ctrl-q to quit demo

Review of attachment 57997:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=46948&attachment=57997)
-----------------------------------------------------------------

Ok.

::: glib/demo/main.c
@@ +370,5 @@
> +	closure = g_cclosure_new (G_CALLBACK (gtk_main_quit), NULL, NULL);
> +	gtk_accel_group_connect (gtk_accel, gdk_keyval_from_name ("q"),
> +				 GDK_CONTROL_MASK, 0, closure);
> +	g_closure_unref (closure);
> +	gtk_window_add_accel_group (GTK_WINDOW(win), gtk_accel);

hmm, I think gtk_window_add_accel_group takes a reference of the accel_group,
so you should probably unref it here

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.