[Poppler-bugs] [Bug 40561] [PATCH] support for LinkMovie object in Qt4 frontend

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Mar 6 13:15:49 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=40561

--- Comment #20 from Albert Astals Cid <tsdgeos at terra.es> 2012-03-06 13:15:49 PST ---
There's broken indentation in 
QString LinkMovie::annotationTitle() const
and
ObjectReference LinkMovie::annotationReference() const

bool LinkMovie::isReferencedAnnotation( const MovieAnnotation *annotation,
const LinkMovie *link )
should not be static and use "this" instead of link

Why would you ever need
bool LinkMovie::isReferencedAnnotation( const MovieAnnotation *annotation,
const QString &annotationTitle, const ObjectReference &annotationReference ) ?

Why someone would want to know the 
ObjectReference annotationReference() const; ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Poppler-bugs mailing list