[Poppler-bugs] [Bug 40561] [PATCH] support for LinkMovie object in Qt4 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40561

--- Comment #22 from Albert Astals Cid <tsdgeos at terra.es> 2012-03-07 11:19:02 PST ---
You should pass the other values to the LinkMoviePrivate constructor, this way
you avoid the akward thing of having LinkMoviePrivate initialize operation to
LinkMovie::Play and then do d->operation = operation;

Also i think it'd be a nice idea if you don't expose
void setPdfObjectReference(const ObjectReference &reference);
since i don't see a reason a user would use it, and simply go behind the scenes
and update d->pdfObjectReference

The since should be 0.20, not 0.8 and are missing in the new functions

And last i remember we were trying to use QSharedDataPointers in stuff like
ObjectReferencePrivate * const d; but i'll accept if you say "nah" on it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.