[Poppler-bugs] [Bug 47186] pdftohtml: mask images are not extracted, unless they are JPEG

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47186

--- Comment #2 from Ihar Filipau <thephilips at gmail.com> 2012-03-10 08:26:39 PST ---
(In reply to comment #1)
> Bad bad, don't copy code.
>
> Create a function with the code you copied.

The core of the PNG code here - the internal loop used to convert the bitmap
into row for PNGWriter with comment "convert bits into a bytes for PNG" - is
unfortunately unique. If you have any ideas how to make the two PNG writers
into single function, I will do it.

At the moment I see that the image file name generation code and probably the
file opening (to move away the error handling) can be separated into a new
method.

Suggestions are welcome.

> Also you changed 
> OutputDev::drawImageMask(state, ref, str, width, height, invert, interpolate,
> inlineImg);
> to 
> OutputDev::drawImage(state, ref, str, width, height, colorMap, interpolate,
>              maskColors, inlineImg);
> in the #else branch

My bad. Will fix.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.