[Poppler-bugs] [Bug 47282] Added media rendition support for Qt4

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47282

--- Comment #6 from Albert Astals Cid <tsdgeos at terra.es> 2012-03-13 15:06:44 PDT ---
What does the loop in ScreenAnnotation::ScreenAnnotation( const QDomNode & node
) do?

What's the point in creating an empty screen elment in ScreenAnnotation::store?

 \since 0.10 needs to be  \since 0.20

Please pass the MediaRendition to LinkRenditionPrivate

poppler-media.h: qt interface to poppler in poppler-media.cc

MediaRendition has no documentation at all

MediaRendition misses some const in the getters (isValid, contentType, etc)

MediaRenditionPrivate *d_ptr; is duplicating what Q_DECLARE_PRIVATE(
MediaRendition ) does?

Please use UnicodeParsedString instead of QString::fromLatin1

Please d-pointify ScreenObject

poppler-screen.cc says poppler-sound.cc: qt interface to poppler

What's the use of passing AnnotScreen *ann to ScreenObject::ScreenObject

What's the use of ScreenObject itself if only holds a LinkRendition ?

Q_DISABLE_COPY to StreamDevice ?

StreamDevice seems like it could to more to implement QIODevice functions like
reset, etc, i understand you decided to say its isSequential to simplify the
job, maybe you should rename StreamDevice to StreamSequentialDevice?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.