[Poppler-bugs] [Bug 2951] evince case-sensitive find isn't

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=2951

--- Comment #10 from Adrian Johnson <ajohnson at redneon.com> 2012-03-20 01:39:04 PDT ---
Comment on attachment 58708
  --> https://bugs.freedesktop.org/attachment.cgi?id=58708
add case sensitive search

Review of attachment 58708:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=2951&attachment=58708)
-----------------------------------------------------------------

::: glib/poppler.h
@@ +180,5 @@
> +  POPPLER_FIND_BACKWARDS         = 1 << 5,
> +  POPPLER_FIND_WHOLE_WORD        = 1 << 6,
> +  POPPLER_FIND_DEFAULT           = POPPLER_FIND_STOP_AT_BOTTOM
> +} PopplerFindFlags;
> +

Exposing all the findText options does not make sense. They are part of the
internal API which may change. They are used for implementing features like
find first/find next. As the poppler_page_find_text_with_options returns all
matches on the page it does not make sense to have options for start from top
or backwards search. These options also will not work as you would expect with
poppler_page_find_text since it runs in a loop with the same options but
reusing the xMin, yMin from the previous call to findText. Normally you would
have one set of options for the first call to findText then change the options
for subsequent calls. eg the first call might use startAtTop=true,
startAtLast=false then the next call will use startAtTop=false,
startAtLast=true.

Also the 'whole word' option is not implemented.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.