[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #105 from Albert Astals Cid <tsdgeos at terra.es> ---
(In reply to comment #103)
> (In reply to comment #102)
> > Yes, having the same rendering is important, but to be honest i like to
> > understand why the code is there and why it does what it does.
> 
> And You really understand every part of poppler code :-) ? 

No, but i understand that the guy sending the code should understand it ;-)

> Therefore a delay of a few days will probably not help. Do You have any
> other suggestions?

As said in coment #22 i think to make the "thread-safety" better we should
remove PDFDoc::getXRef() and force everyone to use Gfx:::getXRef() or ask for
an XRef an input, right?

Of course that is a long term-ish solution.

If you really want this in, i can add the "if" solution with a comment
explaining that that "breaks" in the multithreaded rendering case but still
gives proper rendering and that should be properly fixed in the future.

I'm still going to release beta 2 today, will ask the list how they feel about
adding a new beta 3 that let's us add more features.

Does this work for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121122/c8db779c/attachment.html>