[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #106 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
(In reply to comment #105)
> (In reply to comment #103)
> > (In reply to comment #102)
> > > Yes, having the same rendering is important, but to be honest i like to
> > > understand why the code is there and why it does what it does.
> > 
> > And You really understand every part of poppler code :-) ? 
> 
> No, but i understand that the guy sending the code should understand it ;-)

Hopefully, but sometimes I just use a "best guess" :-)
> 
> > Therefore a delay of a few days will probably not help. Do You have any
> > other suggestions?
> 
> As said in coment #22 i think to make the "thread-safety" better we should
> remove PDFDoc::getXRef() and force everyone to use Gfx:::getXRef() or ask
> for an XRef an input, right?

Agree

> 
> Of course that is a long term-ish solution.

Agree

> 
> If you really want this in, i can add the "if" solution with a comment
> explaining that that "breaks" in the multithreaded rendering case but still
> gives proper rendering and that should be properly fixed in the future.

The XRef-changes are the base for futur code changes! And hopefully the steps
for correct poppler code to be thread safe at all are smaller if we have that
in. One idea I got already yesterday to make the annot stuff thread safe in
removing the doc references and using instead a xref reference. This hopefully
changes only a few file (i.e. Page, Annot, Form and perhaps Catalog).

So another idea: if the patch (together with the small Annot change) doesn't
break single thread page rendering and renders the page almost correctly with
multi thread rendering, can we commit it with the hint, that multi thread
rendering is still experimental? (and of course remove the QT4_MULTITHREAD
directive? Than we and especially I have a base where I can continue working
on, and if possible, we can add the Annot changes I'll make in the very next
futur as bug fix?

> 
> I'm still going to release beta 2 today, will ask the list how they feel
> about adding a new beta 3 that let's us add more features.
> 
> Does this work for you?

Yes, of course!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20121123/d42244a5/attachment.html>