[Poppler-bugs] [Bug 54526] Selection background color turns black

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54526

--- Comment #2 from Jason Crain <jason at aquaticape.us> 2012-09-05 04:56:25 UTC ---
Created attachment 66651
  --> https://bugs.freedesktop.org/attachment.cgi?id=66651
Update fill and stroke color in CairoOutputDev::startPage

The problem occurs because in CairoOutputDev.cc, the current fill color is kept
in two variables: fill_pattern and fill_color.  CairoOutputDev::updateFillColor
checks if fill_color has changed before updating fill_pattern.  But in
CairoOutputDev::startPage, fill_pattern is set to black without updating
fill_color.  When fill_color and fill_pattern become desynchronized,
updateFillColor may fail to update fill_pattern, leaving the pattern black. 
The same is true for the stroke_pattern and stroke_color variables, but I have
not seen any problem caused by that.

Attached patch fixes this problem by updating fill_color and stroke_color in
startPage, to keep them in sync with fill_pattern and stroke_pattern.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.