[Poppler-bugs] [Bug 54617] drawImage is called regardless of needNonText

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54617

Albert Astals Cid <tsdgeos at terra.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Albert Astals Cid <tsdgeos at terra.es> 2012-09-09 10:18:40 UTC ---
If you were trying to suggest this patch

diff --git a/poppler/Gfx.cc b/poppler/Gfx.cc
index d7684d6..34859e8 100644
--- a/poppler/Gfx.cc
+++ b/poppler/Gfx.cc
@@ -4874,6 +4874,9 @@ void Gfx::drawForm(Object *str, Dict *resDict, double
*matrix, double *bbox,
 void Gfx::opBeginImage(Object args[], int numArgs) {
   Stream *str;
   int c1, c2;
+  
+  if (!out->needNonText())
+    return;

   // NB: this function is run even if ocState is false -- doImage() is
   // responsible for skipping over the inline image data

I'm sorry to tell you that the patch is wrong and that it makes pdftotext
extract less text on files like https://bugs.kde.org/attachment.cgi?id=12533 so
I'm closing the bug. If you have other patch in mind please reopen the bug and
attach your patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.